[coop] Reduce verbosity if too many handles used #16181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of issuing a warning, only show the message if the trace level is low enough. Addresses part of mono#16179
marek-safar
approved these changes
Aug 12, 2019
Contributor
|
This has always been a fixable bug. |
|
Now that I have a better understanding of these messages' background, I think I agree with @jaykrell: If this is fixable, then that might be preferable to suppressing a warning that's there for good reason. If properly fixed, this present proposed change here might no longer be necessary in the first place. |
Member
Author
|
Closing in favor of #16184 which should fix one instance of the handles warning that motivated this PR. We should revisit if we see more warnings that are less straightforward to fix properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of issuing a warning, only show the message if the trace level is low
enough.
Addresses part of #16179