[w32socket] Translate some errno codes to WSA_ errors imprecisely. #16331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aren't a perfect match, but better than falling into the `default` case where Mono asserts and crashes. Addresses part of mono#16024
Therzok
approved these changes
Aug 19, 2019
CoffeeFlux
approved these changes
Aug 20, 2019
Contributor
CoffeeFlux
left a comment
There was a problem hiding this comment.
The use of WSAEINVAL and WSA_INVALID_PARAMETER here seems a little suspect, but I guess options are limited.
| #ifdef ECONNRESET | ||
| case ECONNRESET: return WSAECONNRESET; | ||
| #endif | ||
| case EDOM: return WSAEINVAL; /* not a precise match, best wecan do. */ |
Contributor
There was a problem hiding this comment.
Nit: space needed in "wecan".
| case EINTR: return WSAEINTR; | ||
| case EINVAL: return WSAEINVAL; | ||
| /*FIXME: case EIO: return WSAE????; */ | ||
| case EIO: return WSA_INVALID_HANDLE; /* not a precise match, best we can do. */ |
Contributor
There was a problem hiding this comment.
Why this over WSAEBADF?
Member
Author
There was a problem hiding this comment.
#16024 (comment) it's what w32error-unix.c does, kind of.
Member
Author
|
@monojenkins backport to 2019-08 |
This was referenced Aug 26, 2019
akoeplinger
pushed a commit
that referenced
this pull request
Aug 26, 2019
…cisely. (#16489) * [w32socket] Translate some errno codes to WSA_ errors imprecisely. These aren't a perfect match, but better than falling into the `default` case where Mono asserts and crashes. Addresses part of #16024 * [w32error] Add WSA_INVALID_PARAMETER and WSA_INVALID_HANDLE Backport of #16331.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aren't a perfect match, but better than falling into the
defaultcasewhere Mono asserts and crashes.
Addresses part of #16024
Also add
WSA_INVALID_PARAMETERandWSA_INVALID_HANDLEdefines