[corlib] Add hack for Hebrew calendar data #16624
Conversation
|
@monojenkins commit csproj |
|
@monojenkins build Linux AArch64 FullAOT+Interpreter+LLVM |
| [StructLayout (LayoutKind.Sequential)] | ||
| partial class CalendarData | ||
| { | ||
| private static string[] HEBREW_MONTH_NAMES = new[] { |
There was a problem hiding this comment.
Maybe a comment as to roughly what these are? Perhaps the identifier suffice.
or a comment saying ideally it is in native, to avoid fix startup.
There was a problem hiding this comment.
It's a hack anyway, we need to find out why our "ICU" analogue doesn't handle it and fix there (this PR just fixes CI)
There was a problem hiding this comment.
It doesn't handle it because the calendarId is completely ignored, both in managed code and the native code. It was there as TODO for couple of years - TODO: Convert calendar-id to mono runtime calendar-id when it's used. Basically any combination of locale and non-default calendar for given locale is broken.
No one noticed it until now because Hebrew is the only supported calendar with leap months and it was the first leap year since the code was introduced. The produced DateTime.ToString results for the given combination were incorrect since the very beginning but they were round-trippable because the same wrong names were used for parsing.
|
@monojenkins build Linux AArch64 Coop Suspend |
1 similar comment
|
@monojenkins build Linux AArch64 Coop Suspend |
|
@monojenkins backport to 2019-08 |
|
@monojenkins backport to 2019-06 |
|
@monojenkins backport 2019-02 |
[corlib] Add hack for Hebrew calendar data Commit migrated from mono/mono@73c8017
Workaround for #16623. Unblocks the CI, should be back-ported to other branches.
/cc @akoeplinger @jaykrell