[metadata] Fix leaks when handling a few attributes #16675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callers of mono_reflection_create_custom_attr_data_args_noalloc were leaking some of the returned information. Accessed attributes are FixedBufferAttribute and UnmanagedFunctionPointerAttribute.
Contributor
|
Where is the allocation actually happening? Apologies, but I'm very familiar with this part of the codebase and the logic around |
Member
Author
|
@CoffeeFlux the freed values are allocated in load_cattr_value. There are some malloc's there for primitive types |
|
hi, Would it be possible to backport this to https://github.com/mono/mono/commits/2019-02 |
Member
Author
|
@monojenkins backport 2019-08 |
Contributor
|
@BrzVlad backporting to 2019-06 failed, the patch results in conflicts: Please backport manually! |
BrzVlad
added a commit
to BrzVlad/mono
that referenced
this pull request
Sep 16, 2019
Callers of mono_reflection_create_custom_attr_data_args_noalloc were leaking some of the returned information. Accessed attributes are FixedBufferAttribute and UnmanagedFunctionPointerAttribute.
BrzVlad
added a commit
that referenced
this pull request
Sep 16, 2019
Member
Author
|
@MattL0 Forgot to answer, sorry. 2019-02 is already done. This fix will be in the following release / preview. |
|
Thanks ! |
marek-safar
added a commit
that referenced
this pull request
Sep 26, 2019
marek-safar
added a commit
that referenced
this pull request
Sep 26, 2019
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
Callers of mono_reflection_create_custom_attr_data_args_noalloc were leaking some of the returned information. Accessed attributes are FixedBufferAttribute and UnmanagedFunctionPointerAttribute. Commit migrated from mono/mono@e49be5b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callers of mono_reflection_create_custom_attr_data_args_noalloc were leaking some of the returned information. Accessed attributes are FixedBufferAttribute and UnmanagedFunctionPointerAttribute.