[crashing] Remove Mono signal handlers when starting to handle a crash #17002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
approved these changes
Sep 23, 2019
Contributor
Author
|
@monojenkins build failed |
Contributor
|
I wonder if |
jaykrell
reviewed
Sep 24, 2019
| g_assert (sigaction (SIGCHLD, &sa, NULL) != -1); | ||
|
|
||
| /* Remove SIGQUIT, we are already dumping threads */ | ||
| g_assert (sigaction (SIGQUIT, &sa, NULL) != -1); |
Contributor
There was a problem hiding this comment.
g_assert not supposed to have side effects.
Contributor
Author
There was a problem hiding this comment.
@jaykrell This is some code that was moved and complemented, I did not want to make changes to the motif
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@monojenkins backport 2019-08 |
monojenkins
added a commit
that referenced
this pull request
Sep 26, 2019
#17078) [2019-08] [crashing] Remove Mono signal handlers when starting to handle a crash Fixes #16803 Backport of #17002. /cc @marek-safar @alexischr
Member
|
@monojenkins backport to 2019-06 |
Contributor
|
@lambdageek backporting to 2019-06 failed, the patch results in conflicts: Please backport manually! |
lambdageek
pushed a commit
to lambdageek/mono
that referenced
this pull request
Oct 1, 2019
marek-safar
pushed a commit
that referenced
this pull request
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16803