Bug-833 - Path.GetFullPath returns double DirectorySeparatorChar if cwd == DirectorySeparatorChar #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2011 10:21
Contributor
|
Isn't the issue solved with "if (cwd == DirectorySeparatorStr) ..."? |
Author
|
No, because this is also broken on windows. Change your cwd to C:\ then echo the results of Path.GetFullPath("test.txt"). It returned "C:\test.txt" |
Author
|
I just realized I dont think my fix works on Windows. Will reevaluate. I noticed the check for ''. I am working on normalizing 95% of the MonoIO operations so all these checks don't need to happen (In my own project, not these commits). It would be nice to treat the File System in which Mono is running on the same way, except for a few minor mapping calls. I'll check this fix on Windows and resubmit another commit if needed. |
Contributor
|
ping? |
Contributor
|
Closing this due to inactivity, but feel free to resubmit. Thanks! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…rrent bblock using a conditional branch whose two targets are the same. Fixes mono/mono#171. Commit migrated from mono/mono@50d820a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if ending of Directory.GetCurrentDirectory() ends in DirectorySeparatorChar and don't append if it does.
Was concerned about UNC paths, but '\' is invalid. This means that even if GetCurrentDirectory() happened to return a '' an extra DirectorySeparatorChar is invalid.