[2019-08] [merp] Put thread into async context before running summarizer #17197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup work for mono#17090 In order to get managed method info for unmanaged stacktraces, we call mini_jit_info_table_find_ext which calls decode_exception_debug_info which may allocate if it's not in async context. Do the switch in mono_threads_summarize_execute so that non-supervising threads all switch when they run the sigterm_signal_handler. mono_threads_summarize already does it for the supervisor thread. Fixes mono#17180
lambdageek
approved these changes
Oct 5, 2019
Member
|
@monojenkins squash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup work for #17090
In order to get managed method info for unmanaged stacktraces, we call
mini_jit_info_table_find_extwhich callsdecode_exception_debug_infowhich mayallocate if it's not in async context.
Do the switch in
mono_threads_summarize_executeso that non-supervising threadsall switch when they run the
sigterm_signal_handler.mono_threads_summarizealready does it for the supervisor thread.
Fixes #17180
Backport of #17194.
/cc @lambdageek