[2019-02] [2019-06] [debugger][exception] Debugger breaks on handled exceptions #17205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r catch generated by the method called in the owner thread, so we don't need to throw as unhandled exception, we can continue and find the next catch. Fixes mono#17083 Backport of mono#17106.
Contributor
|
@monojenkins build failed |
thaystg
approved these changes
Oct 7, 2019
Contributor
|
@monojenkins build failed |
Contributor
|
This backport is not very risky because is undoing part of something done in this commit 405d521, so there is a small chance of this commit create a new bug. |
Contributor
|
/cc @marek-safar |
Contributor
|
@thaystg why close this? if this is not going to mono 6.4.x can I get a rough idea of when 6.6 will hit stable channel? |
Member
Contributor
|
Ah thanks Alex! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a perform_wait_callback in the stack there will be another catch generated by the method called in the owner thread, so we don't need to throw as unhandled exception, we can continue and find the next catch.
Fixes #17083
Backport of #17106.
Backport of #17203.
/cc @thaystg