Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add null check around sslStream when trying to dispose in MonoTlsStream #17270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
baulig merged 1 commit into from
Nov 19, 2019
Merged

Add null check around sslStream when trying to dispose in MonoTlsStream #17270

baulig merged 1 commit into from
Nov 19, 2019

Conversation

@steveisok
Copy link
Contributor

@steveisok steveisok commented Oct 10, 2019

Fixes #15805 at least in terms of what may be making it crash.

Adds a null check around the sslStream before trying to dispose.

Fixes mono#15805 at least in terms of what may be making it crash.
0fa491b 
Adds a null check around the sslStream before trying to dispose.
@steveisok steveisok requested a review from baulig as a code owner October 10, 2019 17:10
@steveisok steveisok requested a review from akoeplinger October 10, 2019 17:10
@baulig baulig mentioned this pull request Oct 14, 2019
Closed
@baulig
Copy link
Contributor

baulig commented Oct 14, 2019

I have a better idea - checkout my detailed comment here: #15805 (comment).

@steveisok
Copy link
Contributor Author

steveisok commented Oct 14, 2019

Works for me!

@steveisok steveisok closed this Oct 14, 2019
@steveisok steveisok reopened this Oct 28, 2019
@baulig baulig merged commit 0c3ffb9 into mono:master Nov 19, 2019
@baulig
Copy link
Contributor

baulig commented Nov 19, 2019

@monojenkins backport 2019-10

@monojenkins monojenkins mentioned this pull request Nov 19, 2019
Merged
baulig pushed a commit to xamarin/web-tests that referenced this pull request Nov 19, 2019
Add new HttpInstrumentationTests.CloseDuringClientAuth.
e37d866 
This tests mono/mono#17270.
@baulig
Copy link
Contributor

baulig commented Nov 19, 2019

This is pretty much impossible to debug without the web-tests instrumentation framework.

Full test case is here: xamarin/web-tests@e37d866.

You have to guarantee that you're inside MonoTlsStream.CreateStream() here:

mono/mcs/class/System/Mono.Net.Security/MonoTlsStream.cs

Line 117 in 0c3ffb9

await sslStream.AuthenticateAsClientAsync (

And then shut down the connection with a subsequent run of the ServicePointScheduler prior to that AuthenticateAsClientAsync() completing. This will call MonoTlsStream.Dispose() here:

mono/mcs/class/System/System.Net/WebConnection.cs

Line 432 in 0c3ffb9

monoTlsStream.Dispose ();

Note that a call to HttpWebRequest.Abort() is not guaranteed to trigger this (it could race though) because that will only queue, but not run the ServicePointScheduler - so WebConnection.CloseSocket() is called from the thread pool.

@baulig
Copy link
Contributor

baulig commented Nov 19, 2019

I should also add that the NRE was in fact caught and wrapped inside a WebException - but one of the comments mentioned that some debugging tools seem to always treat any thrown (though caught) NRE as a fatal error.

akoeplinger pushed a commit that referenced this pull request Nov 22, 2019
@monojenkins @akoeplinger
2019-10] Add null check around sslStream when trying to dispose in Mo…
ae85289 
…noTlsStream

Fixes #15805 at least in terms of what may be making it crash.

Adds a null check around the sslStream before trying to dispose.

Backport of #17270.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

1 more reviewer

@baulig baulig baulig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mono.Net.Security.MonoTlsStream: Crash when stream appears to have already been disposed

2 participants

@steveisok @baulig