-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Use byte-aligned LLVM loads and stores for unaligned mini IR loads and stores. #18296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lambdageek
merged 1 commit into
mono:master
from
imhameed:bug-gh-18221-unaligned-load-store
Dec 26, 2019
Merged
Use byte-aligned LLVM loads and stores for unaligned mini IR loads and stores. #18296
lambdageek
merged 1 commit into
mono:master
from
imhameed:bug-gh-18221-unaligned-load-store
Dec 26, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d stores. Should fix mono#18221.
filipnavara
approved these changes
Dec 25, 2019
lambdageek
approved these changes
Dec 26, 2019
Member
|
@monojenkins backport to 2019-12 |
Contributor
|
@lambdageek backporting to 2019-10 failed, the patch results in conflicts: Please backport manually! |
Contributor
|
I've verified that this PR fixes the issue on 32bit release mode iOS (with Generated code before: after: Generated bitcode also has the |
monojenkins
added a commit
that referenced
this pull request
Jan 2, 2020
…d stores. (#18301) [2019-12] Use byte-aligned LLVM loads and stores for unaligned mini IR loads and stores. Should fix #18221. Backport of #18296. /cc @lambdageek @imhameed
imhameed
added a commit
to imhameed/mono
that referenced
this pull request
Jan 7, 2020
…R loads and stores. Should fix mono#18221. Backport of mono#18296.
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
…d stores. (mono/mono#18296) Should fix mono/mono#18221. Commit migrated from mono/mono@9719635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #18221.