Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[corlib] Switch to CharUnicodeInfo from corefx #18305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marek-safar merged 2 commits into from
Jan 9, 2020
Merged

[corlib] Switch to CharUnicodeInfo from corefx #18305

marek-safar merged 2 commits into from
Jan 9, 2020

Conversation

@marek-safar
Copy link
Member

@marek-safar marek-safar commented Dec 27, 2019

No description provided.

@steveisok
Copy link
Contributor

steveisok commented Dec 27, 2019

The mcs failure is significant.

The wasm one may be, but not 100% sure.

WASM: FAIL: System.Buffers.Text.Tests.Base64EncoderUnitTests.BasicEncodingWithFinalBlockFalse
WASM: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.OutOfMemoryException: Out of memory
WASM:   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
WASM:   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) <0x34297f0 + 0x000ce> in <758e4f696ce0429c87765a52350cb572>:0 
WASM:    --- End of inner exception stack trace ---
WASM:   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) <0x34297f0 + 0x000f6> in <758e4f696ce0429c87765a52350cb572>:0 
WASM:   at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) <0x37ba2e8 + 0x00014> in <758e4f696ce0429c87765a52350cb572>:0 
WASM:   at WasmRunner.Run () <0x37190c8 + 0x00766> in <0d91d0de794645e09cfd3d0c7a47b7d2>:0

@lambdageek lambdageek mentioned this pull request Dec 27, 2019
Merged
@marek-safar marek-safar force-pushed the corlib-size branch 2 times, most recently from 4f4eaac to 0bbb808 Compare December 28, 2019 09:44
@NattyNarwhal
Copy link
Contributor

NattyNarwhal commented Dec 29, 2019

Careful, I remember a switch from custom refsrc to normal refsrc failed because of some endianness BS caused by some crazy pointer arith in refsrc's Unicode char info classes

@marek-safar
Copy link
Member Author

marek-safar commented Jan 2, 2020

@monojenkins build failed

@marek-safar
Copy link
Member Author

marek-safar commented Jan 3, 2020

It looks like we have GC problem handling large Span blocks. @BrzVlad is this enough for you to investigate (it repros consistently) ?

@marek-safar
Copy link
Member Author

marek-safar commented Jan 8, 2020

@monojenkins commit csproj

@marek-safar marek-safar merged commit 9cc751d into mono:master Jan 9, 2020
@marek-safar marek-safar deleted the corlib-size branch January 9, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@EgorBo EgorBo Awaiting requested review from EgorBo

@steveisok steveisok Awaiting requested review from steveisok

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marek-safar @steveisok @NattyNarwhal @akoeplinger @monojenkins