Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add SignedCms to the TypeForwards in the System.Security.Cryptography.Pkcs facade #18325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 6 commits into from
Jan 7, 2020
Merged

Add SignedCms to the TypeForwards in the System.Security.Cryptography.Pkcs facade #18325

akoeplinger merged 6 commits into from
Jan 7, 2020

Conversation

@steveisok
Copy link
Contributor

@steveisok steveisok commented Dec 30, 2019

Fixes #18323

@marek-safar
Copy link
Member

marek-safar commented Dec 31, 2019

There are about 48 types in netstandard version, we should add them all (even if with PNSE)

@EgorBo
Copy link
Member

EgorBo commented Dec 31, 2019

@marek-safar the type is not part of the NS (at least 2.x) as far as I understand.

@marek-safar
Copy link
Member

marek-safar commented Dec 31, 2019

This is BCL not netstandard assembly so we can provide our own API but considering there are no . for Xamarin we should be a superset of NS2.1 implementation.

@steveisok
Copy link
Contributor Author

steveisok commented Jan 2, 2020

In looking at the System.Security.Cryptography.Pkcs netstandard 2.1 package, these types are not in our facade:

System.Security.Cryptography.Pkcs.CmsSigner
System.Security.Cryptography.Pkcs.Pkcs12Builder
System.Security.Cryptography.Pkcs.Pkcs12CertBag
System.Security.Cryptography.Pkcs.Pkcs12ConfidentialityMode
System.Security.Cryptography.Pkcs.Pkcs12Info
System.Security.Cryptography.Pkcs.Pkcs12IntegrityMode
System.Security.Cryptography.Pkcs.Pkcs12KeyBag
System.Security.Cryptography.Pkcs.Pkcs12SafeBag
System.Security.Cryptography.Pkcs.Pkcs12SafeContents
System.Security.Cryptography.Pkcs.Pkcs12SafeContentsBag
System.Security.Cryptography.Pkcs.Pkcs12SecretBag
System.Security.Cryptography.Pkcs.Pkcs12ShroudedKeyBag
System.Security.Cryptography.Pkcs.Pkcs8PrivateKeyInfo
System.Security.Cryptography.Pkcs.Pkcs9LocalKeyId
System.Security.Cryptography.Pkcs.Rfc3161TimestampRequest
System.Security.Cryptography.Pkcs.Rfc3161TimestampToken
System.Security.Cryptography.Pkcs.Rfc3161TimestampTokenInfo
System.Security.Cryptography.Pkcs.SignerInfo
System.Security.Cryptography.Pkcs.SignerInfoCollection
System.Security.Cryptography.Pkcs.SignerInfoEnumerator

@steveisok
Copy link
Contributor Author

steveisok commented Jan 6, 2020

@monojenkins build failed

@steveisok
Copy link
Contributor Author

steveisok commented Jan 7, 2020

@monojenkins commit apidiff and csproj

monojenkins added a commit to mono/api-snapshot that referenced this pull request Jan 7, 2020
@monojenkins
Apply changes from mono/mono#18325 to API snapshot
c58c68d
@steveisok steveisok requested a review from marek-safar as a code owner January 7, 2020 02:34
@akoeplinger akoeplinger merged commit 0ccf503 into mono:master Jan 7, 2020
@steveisok
Copy link
Contributor Author

steveisok commented Jan 7, 2020

@monojenkins backport 2019-12

@steveisok
Copy link
Contributor Author

steveisok commented Jan 7, 2020

@monojenkins backport 2019-10

This was referenced Jan 7, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marek-safar marek-safar marek-safar approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

+1 more reviewer

@EgorBo EgorBo EgorBo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error MT2101: Can't resolve the reference 'System.Security.Cryptography.Pkcs.SignedCms'

5 participants

@steveisok @marek-safar @EgorBo @akoeplinger @monojenkins