Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[runtime] Initialize field info before accessing it in ves_icall_System_RuntimeFieldHandle_SetValueDirect (). #18378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vargaz merged 1 commit into from
Jan 8, 2020
Merged

[runtime] Initialize field info before accessing it in ves_icall_System_RuntimeFieldHandle_SetValueDirect (). #18378

vargaz merged 1 commit into from
Jan 8, 2020

Conversation

@vargaz
Copy link
Contributor

@vargaz vargaz commented Jan 8, 2020

Fixes #18364.

thaystg
thaystg approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@thaystg thaystg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lambdageek
Copy link
Member

lambdageek commented Jan 8, 2020

@monojenkins backport to 2019-12

@monojenkins
Copy link
Contributor

monojenkins commented Jan 8, 2020

@lambdageek backporting to 2019-12 failed, the patch results in conflicts:

Applying: [runtime] Initialize field info before accessing it in ves_icall_System_RuntimeFieldHandle_SetValueDirect ().
Using index info to reconstruct a base tree...
M	mono/metadata/class-internals.h
M	mono/metadata/icall.c
Falling back to patching base and 3-way merge...
Auto-merging mono/metadata/icall.c
Auto-merging mono/metadata/class-internals.h
CONFLICT (content): Merge conflict in mono/metadata/class-internals.h
error: Failed to merge in the changes.
Patch failed at 0001 [runtime] Initialize field info before accessing it in ves_icall_System_RuntimeFieldHandle_SetValueDirect ().

Please backport manually!

@vargaz vargaz merged commit 34dee0e into mono:master Jan 8, 2020
@vargaz vargaz deleted the fix-18364 branch January 8, 2020 15:39
ManickaP pushed a commit to ManickaP/runtime that referenced this pull request Jan 20, 2020
@vargaz
[runtime] Initialize field info before accessing it in ves_icall_Syst…
f4ab938 
…em_RuntimeFieldHandle_SetValueDirect (). (mono/mono#18378)

Fixes mono/mono#18364.

Commit migrated from mono/mono@34dee0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lambdageek lambdageek Awaiting requested review from lambdageek

1 more reviewer

@thaystg thaystg thaystg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect Reflection & TypedReference behavior in AOT mode.

4 participants

@vargaz @lambdageek @monojenkins @thaystg