[2019-12] [debugger] Enable reading embedded ppdb #19050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
approved these changes
Feb 26, 2020
lambdageek
approved these changes
Feb 27, 2020
Member
|
We might want to proactively bump XA/XI to this commit to make sure it doesn't cause issues for them. |
Contributor
|
Testing this in VSMac, and it's working as intended for us. We've reduced the number of pdbs in the bundle by quite a few |
Contributor
|
Sooo, from the looks of it, VSMac is lucky and the build infrastructure sets the |
Contributor
|
@akoeplinger , I'll do this. |
Contributor
|
Xamarin-Macios -> dotnet/macios#7998 |
Contributor
|
Xamarin-Android -> dotnet/android#4335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #18895
Backport of #19049.
/cc @thaystg