[merp] Create a signal ('source') breadcrumb for the crash dump process #19072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
previously requested changes
Feb 28, 2020
Member
lambdageek
left a comment
There was a problem hiding this comment.
looks ok.
- I don't like
signal. Maybedump_cause? argh, naming is difficult. - The
create_foo_breadcrumbfunctions should be less copy/pasted. - What do you think about adding some kind of
BreadcrumbTypeenum and using that to pick thefile_for_whatever_bitmapfunction? that way we don't have to copy/paste too much if we need to add an additional breadcrumb once we know some additional stuff that we want to preserve?
4e4de4a to
859c8d5
Compare
For example, the system name of a signal ('segv') or 'MANAGED_EXCEPTION' are typical arguments.
859c8d5 to
3436ce8
Compare
Updated with some refactoring & more palatable argument name. I did not go for the enum yet
Contributor
Author
|
@monojenkins build pkg |
alexischr
commented
Mar 2, 2020
| create_stage_mark_file (void) | ||
| file_for_dump_reason_breadcrumb (const char *directory, const char *dump_reason, gchar *buff, size_t sizeof_buff) | ||
| { | ||
| g_snprintf (buff, sizeof_buff, "%s%scrash_reason_%s", directory, G_DIR_SEPARATOR_S, dump_reason); |
Contributor
Author
There was a problem hiding this comment.
Btw both of these breadcrumbs should be dump_stage and dump_reason (since we now have crash_stage breadcrumbs from managed exception reporting)
Member
There was a problem hiding this comment.
I think colloquially an unhandled managed exception is a "crash" too. I wouldn't worry too much about the distinction in the file names.
Contributor
Author
|
@monojenkins build failed |
lambdageek
approved these changes
Mar 3, 2020
4 tasks
Contributor
Author
|
@monojenkins backport to 2020-02 |
This was referenced Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @kdubau @lambdageek
Addresses #18715