[llvm] Don't set the LLVM JIT TLS variable in AOT. #19127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix mono#19115. This bug was introduced in mono#18824, which conditionally initalized an LLVM JIT-related TLS slot while preserving unconditonal stores to that same slot. The value stored in this TLS slot should only be used during JIT compilation, so set/reset it in `mono_llvm_compile_method` instead of during IR construction in `mono_llvm_emit_method`. No non-JIT code should depend on the existence or presence of this TLS variable, so remove `mono_llvm_jit_set_tls_cfg`.
vargaz
approved these changes
Mar 5, 2020
Contributor
Author
|
@monojenkins build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #19115. This bug was
introduced in #18824, which
conditionally initalized an LLVM JIT-related TLS slot while preserving
unconditonal stores to that same slot.
The value stored in this TLS slot should only be used during JIT
compilation, so set/reset it in
mono_llvm_compile_methodinstead ofduring IR construction in
mono_llvm_emit_method. No non-JIT codeshould depend on the existence of this TLS variable, so
remove
mono_llvm_jit_set_tls_cfg.