Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[2020-02] [merp] Create a signal ('source') breadcrumb for the crash dump process #19120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexischr merged 1 commit into from
Mar 9, 2020
Merged

[2020-02] [merp] Create a signal ('source') breadcrumb for the crash dump process #19120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mono/metadata/icall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6480,7 +6480,7 @@ ves_icall_Mono_Runtime_ExceptionToState (MonoExceptionHandle exc_handle, guint64
// FIXME: Push handles down into mini/mini-exceptions.c
MonoException *exc = MONO_HANDLE_RAW (exc_handle);
MonoThreadSummary out;
mono_summarize_timeline_start ();
mono_summarize_timeline_start ("ExceptionToState");
mono_summarize_timeline_phase_log (MonoSummarySuspendHandshake);
mono_summarize_timeline_phase_log (MonoSummaryUnmanagedStacks);
mono_get_eh_callbacks ()->mono_summarize_exception (exc, &out);
Expand Down Expand Up @@ -6643,7 +6643,7 @@ ves_icall_Mono_Runtime_DumpStateTotal (guint64 *portable_hash, guint64 *unportab

mono_get_runtime_callbacks ()->install_state_summarizer ();

mono_summarize_timeline_start ();
mono_summarize_timeline_start ("DumpStateTotal");

gboolean success = mono_threads_summarize (ctx, &out, &hashes, TRUE, FALSE, scratch, MONO_MAX_SUMMARY_LEN_ICALL);
mono_summarize_timeline_phase_log (MonoSummaryCleanup);
Expand Down
2 changes: 1 addition & 1 deletion mono/mini/mini-posix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,7 @@ dump_native_stacktrace (const char *signal, MonoContext *mctx)
g_async_safe_printf ("=================================================================\n");

if (!leave) {
mono_summarize_timeline_start ();
mono_summarize_timeline_start (signal);
mono_summarize_toggle_assertions (TRUE);

int mono_max_summary_len = 10000000;
Expand Down
42 changes: 34 additions & 8 deletions mono/utils/mono-state.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,18 +145,43 @@ static const char *configured_timeline_dir;
static MonoSummaryTimeline log;

static void
file_for_summary_stage (const char *directory, MonoSummaryStage stage, gchar *buff, size_t sizeof_buff)
file_for_stage_breadcrumb (const char *directory, MonoSummaryStage stage, gchar *buff, size_t sizeof_buff)
{
g_snprintf (buff, sizeof_buff, "%s%scrash_stage_%d", directory, G_DIR_SEPARATOR_S, stage);
}

static void
create_stage_mark_file (void)
file_for_dump_reason_breadcrumb (const char *directory, const char *dump_reason, gchar *buff, size_t sizeof_buff)
{
g_snprintf (buff, sizeof_buff, "%s%scrash_reason_%s", directory, G_DIR_SEPARATOR_S, dump_reason);
}

static void create_breadcrumb (const char *path)
{
int handle = g_open (path, O_WRONLY | O_CREAT, S_IWUSR | S_IRUSR | S_IRGRP | S_IROTH);
if (handle < 0) {
g_async_safe_printf ("Failed to create breadcrumb file %s\n", path);
return;
}

if (close(handle) < 0)
g_async_safe_printf ("Failed to close breadcrumb file %s\n", path);
}

static void
create_stage_breadcrumb (void)
{
char out_file [200];
file_for_stage_breadcrumb (log.directory, log.level, out_file, sizeof(out_file));
create_breadcrumb (out_file);
}

static void
create_dump_reason_breadcrumb (const char *dump_reason)
{
char out_file [200];
file_for_summary_stage (log.directory, log.level, out_file, sizeof(out_file));
int handle = g_open (out_file, O_WRONLY | O_CREAT, S_IWUSR | S_IRUSR | S_IRGRP | S_IROTH);
close(handle);
file_for_dump_reason_breadcrumb (log.directory, dump_reason, out_file, sizeof(out_file));
create_breadcrumb (out_file);
}

gboolean
Expand All @@ -172,14 +197,15 @@ mono_summarize_set_timeline_dir (const char *directory)
}

void
mono_summarize_timeline_start (void)
mono_summarize_timeline_start (const char *dump_reason)
{
memset (&log, 0, sizeof (log));

if (!configured_timeline_dir)
return;

log.directory = configured_timeline_dir;
create_dump_reason_breadcrumb (dump_reason);
mono_summarize_timeline_phase_log (MonoSummarySetup);
}

Expand Down Expand Up @@ -246,7 +272,7 @@ mono_summarize_timeline_phase_log (MonoSummaryStage next)
g_assertf(out_level == next || next == MonoSummaryDoubleFault, "Log Error: Log transition to %d, actual expected next step is %d\n", next, out_level);

log.level = out_level;
create_stage_mark_file ();
create_stage_breadcrumb ();
// To check, comment out normally
// DO NOT MERGE UNCOMMENTED
// As this does a lot of FILE io
Expand Down Expand Up @@ -323,7 +349,7 @@ static gboolean
timeline_has_level (const char *directory, char *log_file, size_t log_file_size, gboolean clear, MonoSummaryStage stage)
{
memset (log_file, 0, log_file_size);
file_for_summary_stage (directory, stage, log_file, log_file_size);
file_for_stage_breadcrumb (directory, stage, log_file, log_file_size);
gboolean exists = g_file_test (log_file, G_FILE_TEST_EXISTS);
if (clear && exists)
remove (log_file);
Expand Down
2 changes: 1 addition & 1 deletion mono/utils/mono-state.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ gboolean
mono_summarize_set_timeline_dir (const char *directory);

void
mono_summarize_timeline_start (void);
mono_summarize_timeline_start (const char *dump_reason);

void
mono_summarize_timeline_phase_log (MonoSummaryStage stage);
Expand Down