[corlib] Capture the ExceptionDispatchInfo when rethrowing from TaskContinuation #19168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
With this PR, the example from the bug report has a much more complete stack trace: |
Member
Author
|
dotnet/runtime does something similar with Capture and Throw, but in ExecutionContext |
…ontinuation In `task.GetAwaiter().OnCompleted(action)` if `action` throws, the `TaskContinuation.RunOrScheduleAction method will catch the exception and then call `RuntimeAugments.ReportUnhandledException`. We must not simply throw the exception again - in that case we will lose all the frames leading up to the `catch` in `RunOrScheduleAction`. Instead use ExceptionDispatchInfo to caputure the original throw. Addresses mono#19166
1f82f1d to
4a63158
Compare
e744841 to
4d7d9e2
Compare
Member
Author
|
We need to backport this all the way back to 2019-10 for @kdubau |
For annoying reasons we can't run this as a simple NUnit test because the exception is unhandled on some arbitrary threadpool worker thread, and those don't show up within an NUnit setup. Additionally because the unhandled exception in the root domain would normally terminate the application, we need to run this in a new appdomain.
4d7d9e2 to
682a7a0
Compare
steveisok
approved these changes
Mar 12, 2020
Member
Author
|
@monojenkins backport to 2020-02 |
This was referenced Mar 12, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
task.GetAwaiter().OnCompleted(action)ifactionthrows, theTaskContinuation.RunOrScheduleActionmethod will catch the exception and then callRuntimeAugments.ReportUnhandledException. We must not simply throw the exception again - in that case we will lose all the frames leading up to thecatchinRunOrScheduleAction. Instead useExceptionDispatchInfoto capture the original throw.Addresses #19166