Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mdh1418
Copy link
Contributor

@mdh1418 mdh1418 commented Mar 30, 2020

Bump corefx to get mono/corefx#395
The plan for this PR is to:
Successfully build with corefx bump
Merge mono/corefx PR mono/corefx#395
Then merge this PR

@mdh1418 mdh1418 force-pushed the mdhwang/update_filesystem_file_move branch from 7544a66 to 5b2560a Compare March 30, 2020 21:24
@mdh1418 mdh1418 requested a review from alexischr March 30, 2020 21:25
@mdh1418 mdh1418 force-pushed the mdhwang/update_filesystem_file_move branch from 5b2560a to 54b8f93 Compare April 2, 2020 18:31
@akoeplinger
Copy link
Member

@monojenkins build failed

@akoeplinger
Copy link
Member

@monojenkins backport 2020-02

@akoeplinger
Copy link
Member

@mdh1418 FYI we got a request to backport this to 2019-12 as well which can't be done automatically because 2019-12 points to a different branch in mono/corefx so the @monojenkins backport doesn't work.

I backported the fix in mono/corefx: mono/corefx#396 to the right branch, can you please open another PR to bump the corefx submodule in the mono/mono 2019-12 branch to that commit (i.e. commit 033b1842196af20feec30a52be84dfdd52cf5d84)?

@akoeplinger akoeplinger merged commit c6ff50e into mono:master Apr 3, 2020
@mdh1418 mdh1418 deleted the mdhwang/update_filesystem_file_move branch April 3, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants