[wasm][debugger] Show signature for delegate, or target, if available #19505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As object properties, we return a `Target` which has the signature of the delegate target. Fixes mono#19382
df027e1 to
6d24af1
Compare
Member
Author
|
This is based on changes from #19490, so this doesn't target |
lewing
reviewed
Apr 13, 2020
lewing
reviewed
Apr 13, 2020
| * generating this for the delegate, and it's target. | ||
| */ | ||
| static GString* | ||
| mono_method_to_desc_for_js (MonoMethod *method, gboolean include_namespace) |
Member
There was a problem hiding this comment.
This looks like it could be simplified and reduce allocations with a g_string_printf? Maybe just moved inline?
.. as suggested by @lewing
lewing
approved these changes
Apr 14, 2020
Member
|
@monojenkins backport 3.2-wasm |
Contributor
|
@lewing backporting to 3.2-wasm failed, the patch results in conflicts: Please backport manually! |
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Apr 14, 2020
…mono#19505) * [wasm][debugger] Show signature for delegate, or target, if available - As object properties, we return a `Target` which has the signature of the delegate target. Fixes mono#19382 * [wasm][debugger] Some tidying up * [wasm][debugger] Remove unused `sig_desc` * [wasm][debugger] Simplify code, avoid extra allocations .. as suggested by @lewing (cherry picked from commit 4eca12e)
radical
added a commit
that referenced
this pull request
Apr 14, 2020
…#19505) (#19536) * [wasm][debugger] Show signature for delegate, or target, if available - As object properties, we return a `Target` which has the signature of the delegate target. Fixes #19382 * [wasm][debugger] Some tidying up * [wasm][debugger] Remove unused `sig_desc` * [wasm][debugger] Simplify code, avoid extra allocations .. as suggested by @lewing (cherry picked from commit 4eca12e) Co-authored-by: Ankit Jain <[email protected]>
radical
added a commit
to radical/mono
that referenced
this pull request
Apr 15, 2020
…mono#19505) * [wasm][debugger] Show signature for delegate, or target, if available - As object properties, we return a `Target` which has the signature of the delegate target. Fixes mono#19382 * [wasm][debugger] Some tidying up * [wasm][debugger] Remove unused `sig_desc` * [wasm][debugger] Simplify code, avoid extra allocations .. as suggested by @lewing (cherry picked from commit 4eca12e)
lewing
pushed a commit
that referenced
this pull request
Apr 17, 2020
#19535) * [wasm][debugger] Show signature for delegate, or target, if available (#19505) * [wasm][debugger] Show signature for delegate, or target, if available - As object properties, we return a `Target` which has the signature of the delegate target. Fixes #19382 * [wasm][debugger] Some tidying up * [wasm][debugger] Remove unused `sig_desc` * [wasm][debugger] Simplify code, avoid extra allocations .. as suggested by @lewing (cherry picked from commit 4eca12e) * [wasm][debugger] Fix tests broken because unused vars are not null .. anymore, which is because we disabled optimizations in the interpreter when debugging. * [wasm][debugger][tests] Add tests to also check delegates in previous .. frames. * [wasm][debugger] Disable a test that tried to look at previous async .. frames. This just happened to work. Currently, the trace has details of the async machinery, instead of one reflecting what it might have looked like for a non-async case. So, we can't reliably find the previous method to inspect it's locals. * [wasm][debugger] Fix test
lewing
pushed a commit
to lewing/mono
that referenced
this pull request
Apr 17, 2020
mono#19535) * [wasm][debugger] Show signature for delegate, or target, if available (mono#19505) * [wasm][debugger] Show signature for delegate, or target, if available - As object properties, we return a `Target` which has the signature of the delegate target. Fixes mono#19382 * [wasm][debugger] Some tidying up * [wasm][debugger] Remove unused `sig_desc` * [wasm][debugger] Simplify code, avoid extra allocations .. as suggested by @lewing (cherry picked from commit 4eca12e) * [wasm][debugger] Fix tests broken because unused vars are not null .. anymore, which is because we disabled optimizations in the interpreter when debugging. * [wasm][debugger][tests] Add tests to also check delegates in previous .. frames. * [wasm][debugger] Disable a test that tried to look at previous async .. frames. This just happened to work. Currently, the trace has details of the async machinery, instead of one reflecting what it might have looked like for a non-async case. So, we can't reliably find the previous method to inspect it's locals. * [wasm][debugger] Fix test
lewing
added a commit
that referenced
this pull request
Apr 17, 2020
#19535) (#19579) * [wasm][debugger] Show signature for delegate, or target, if available (#19505) * [wasm][debugger] Show signature for delegate, or target, if available - As object properties, we return a `Target` which has the signature of the delegate target. Fixes #19382 * [wasm][debugger] Some tidying up * [wasm][debugger] Remove unused `sig_desc` * [wasm][debugger] Simplify code, avoid extra allocations .. as suggested by @lewing (cherry picked from commit 4eca12e) * [wasm][debugger] Fix tests broken because unused vars are not null .. anymore, which is because we disabled optimizations in the interpreter when debugging. * [wasm][debugger][tests] Add tests to also check delegates in previous .. frames. * [wasm][debugger] Disable a test that tried to look at previous async .. frames. This just happened to work. Currently, the trace has details of the async machinery, instead of one reflecting what it might have looked like for a non-async case. So, we can't reliably find the previous method to inspect it's locals. * [wasm][debugger] Fix test Co-authored-by: Ankit Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targetwhich has the signature ofthe delegate target.
Fixes #19382