[wasm][debugger] Show pointer type+address #19537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is based on #19535, so it includes changes from that. Once it gets merged, I can rebase this. |
Member
|
@monojenkins build failed |
lewing
approved these changes
Apr 14, 2020
lewing
suggested changes
Apr 14, 2020
Member
lewing
left a comment
There was a problem hiding this comment.
You need to change the mono_wasm_add_array_item call on the runtime side
lewing
reviewed
Apr 14, 2020
lewing
reviewed
Apr 14, 2020
lewing
approved these changes
Apr 14, 2020
lewing
approved these changes
Apr 14, 2020
Member
|
@monojenkins build failed |
5cc4b43 to
c37a357
Compare
Member
|
@monojenkins build Linux AArch64 Coop Suspend |
Member
|
@monojenkins build failed |
.. library_mono.js .
c37a357 to
e4b70af
Compare
Member
|
@monojenkins build Linux AArch64 FullAOT+LLVM |
Member
|
@monojenkins build failed |
Member
|
@monojenkins backport 3.2-wasm |
Contributor
|
@lewing backporting to 3.2-wasm failed, the patch results in conflicts: Please backport manually! |
lewing
pushed a commit
to lewing/mono
that referenced
this pull request
Apr 17, 2020
* [wasm][debugger] Simplify the interface between debugger.c and .. library_mono.js . * [wasm][debugger] Show pointer type+address * [wasm][debugger] Address review feedback * [wasm][debugger] Small cleanups, from review feedback * [wasm][debugger] declare mono_wasm_add_typed_value as extern
lewing
added a commit
that referenced
this pull request
Apr 17, 2020
* [wasm][debugger] Simplify the interface between debugger.c and .. library_mono.js . * [wasm][debugger] Show pointer type+address * [wasm][debugger] Address review feedback * [wasm][debugger] Small cleanups, from review feedback * [wasm][debugger] declare mono_wasm_add_typed_value as extern Co-authored-by: Ankit Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.