Show dot-folders in folder browser #10320
Conversation
|
approve /cc @filipnavara |
|
I am not sure that this is such a great idea. I do agree that there should be a way to access the hidden folders. The managed implementation mimics the Windows file open dialog. In Windows you can type the path into the file name field to open it and that works whether it is hidden or not. I didn't check if the Mono implementation allows that, but my hunch is that it could be broken. Similar mechanisms work on other systems too. On macOS the default behavior is also to hide hidden folders, but one can press CMD+SHIFT+G and enter a path directly in the same way as Windows allows it. |
|
I just realized that it affects only Update: On Windows there's only a global system setting to show hidden folders. If that's too big of a change then I would at least prefer to have the behavior consistent between different dialogs and show the hidden folders also in |
|
Hmm, While I agree that an overhaul of |
|
@filipnavara Should this PR be closed? Your suggestion seems reasonable, but I don't want to hold a PR open if the implementation is going to be different. |
|
OK, I'm closing this one. Please consult our old pull request policy for more info. |
|
Sorry, it fell off my radar. For the record I would be fine if we introduced an environment variable to force showing the dot-files until a better solution is available. |
Problem
Mono's
FolderBrowserDialogalways hides folders with names that start with ".".Some important folders have such names, for example
.local/share/Steam/SteamApps/common/, or.local/share/MyApp/.This behavior could be seen as a sensible default if there was a way for developers to control it, since these folders are traditionally treated as "hidden." However, there is no way to control this behavior; the check is hard-coded, and so some of the folders that exist on disk and may be important to display simply never appear. If an application needs to allow a user to choose a folder with a name that starts with ".", or a folder inside a folder with a name that starts with ".", alternatives to the standard
FolderBrowserDialogclass must be pursued, such as a text box for manually editing a path.Showing hidden folders may be awkward in some use cases, but hiding them is much worse when they're needed.
Changes
This filter is now removed. Folders that start with "." now appear in the folder browser.