Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[2018-06] Use clonefile instead of copyfile on macOS #10455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
monojenkins merged 2 commits into from
Sep 5, 2018
Merged

[2018-06] Use clonefile instead of copyfile on macOS #10455

monojenkins merged 2 commits into from
Sep 5, 2018

Conversation

@lewurm
Copy link
Contributor

@lewurm lewurm commented Sep 3, 2018

lewurm and others added 2 commits September 3, 2018 23:43
@lewurm
Revert "[w32file] Fix usage of copyfile (mono#10010)"
99f3086 
This reverts commit 341142d.
@filipnavara @lewurm
Use clonefile instead of copyfile on macOS. (mono#10020)
0d9c68b 
* Use clonefile instead of copyfile on macOS.

* Address PR review comments.

* Address PR review comments (if -> assert).

* RTLD_DEFAULT - > libc_handle
@lewurm lewurm added this to the 2018-06 (5.16.xx) milestone Sep 3, 2018
@lewurm lewurm requested review from luhenry and rolfbjarne September 3, 2018 21:59
@lewurm
Copy link
Contributor Author

lewurm commented Sep 4, 2018

@monojenkins build failed

@lewurm
Copy link
Contributor Author

lewurm commented Sep 5, 2018

@monojenkins squash

@lewurm
Copy link
Contributor Author

lewurm commented Sep 5, 2018

@monojenkins build OS X i386

previous failed build: https://jenkins.mono-project.com/job/test-mono-pull-request-i386-osx/14287/

@monojenkins monojenkins merged commit 9439ee6 into mono:2018-06 Sep 5, 2018
@lewurm lewurm mentioned this pull request Sep 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne

1 more reviewer

@luhenry luhenry luhenry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2018-06 (5.16.xx)

Development

Successfully merging this pull request may close these issues.

4 participants

@lewurm @luhenry @monojenkins @filipnavara