Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump msbuild to track xplat-master #10668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 2 commits into from
Sep 28, 2018
Merged

Bump msbuild to track xplat-master #10668

akoeplinger merged 2 commits into from
Sep 28, 2018

Conversation

@radical
Copy link
Member

@radical radical commented Sep 18, 2018

No description provided.

@radical
Copy link
Member Author

radical commented Sep 18, 2018

@monojenkins build OS X Extended

@radical radical requested a review from marek-safar September 18, 2018 14:44
@radical
Copy link
Member Author

radical commented Sep 18, 2018

@monojenkins build OS X Extended

@radical
Copy link
Member Author

radical commented Sep 19, 2018

hm build aborted for some reason?

@monojenkins build OS X Extended

@radical
Copy link
Member Author

radical commented Sep 19, 2018 

10:06:22 CSC     [net_4_x-macos] net_4_x_corlib_test.dll
10:33:04 Scheduled restart of the build (up to 1 times).
10:33:04 Build timed out (after 420 minutes). Marking the build as aborted.
10:33:04 make: *** [do-run-test] Terminated: 15
10:33:04 make[1]: *** [../../class/lib/net_4_x/tests/net_4_x_corlib_test.dll] Terminated: 15
10:33:04 Build was aborted

@marek-safar
Copy link
Member

marek-safar commented Sep 20, 2018

@monojenkins build OS X Extended

@marek-safar marek-safar added this to the 2018-08 (5.18.xx) milestone Sep 24, 2018
@radical radical mentioned this pull request Sep 27, 2018
Closed
@radical
Copy link
Member Author

radical commented Sep 27, 2018

@monojenkins build OS X Extended

@radical
Copy link
Member Author

radical commented Sep 28, 2018

Multiple runtime crashes in the logs. But all the msbuild tests passed. Can we merge this @akoeplinger? Um though maybe pop off that top debug commit. I'm not pushing so that you can verify the results.

@akoeplinger
Copy link
Member

akoeplinger commented Sep 28, 2018

The runtime test failures in the LLVM-based BCL tests are expected, see #9198.

I think we can keep the debugging commit, it can't hurt :)

@akoeplinger akoeplinger merged commit ced11fb into mono:2018-08 Sep 28, 2018
This was referenced Sep 28, 2018
Closed
Merged
@radical radical deleted the bump_msbuild_2018-08 branch December 18, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@alexischr alexischr Awaiting requested review from alexischr

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2018-08 (5.18.xx)

Development

Successfully merging this pull request may close these issues.

3 participants

@radical @marek-safar @akoeplinger