[Reflection] Use actual type of element if constructor of custom attribute typed argument takes an array of objects. #10972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marek-safar
requested changes
Oct 4, 2018
| Assert.AreEqual (typeof (int), arr [1].Value.GetType (), $"{methodName}#10"); | ||
| } | ||
|
|
||
| private void CheckObjectArrayParams () |
Member
There was a problem hiding this comment.
Should be just normal [Test] method
| // https://github.com/mono/mono/issues/10951 | ||
| public void ObjectArrays () | ||
| { | ||
| CheckObjectArrayParam (nameof (MethodDecoratedWithAttribute3)); |
Member
There was a problem hiding this comment.
It's fine to duplicate the test code
marek-safar
approved these changes
Oct 4, 2018
Member
|
@monojenkins backport 2018-10 |
Contributor
Author
|
Seems that another issue should be resolved here. |
Member
|
There is a lot of failing tests |
Member
|
@monojenkins backport 2018-10 |
Contributor
Author
|
Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several unit tests. The fix is in mono/corert#27.
Fixes #10951