Add option to integrate msvc build into regular make build. #11343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@monojenkins build failed |
Add support to perform msvc build as part of regular make build. By default msvc build will not automatically be done and needs to be enabled using --with-msvc argument passed to ./autogen.sh. Doing msvc build as part of regular make will automatically set MONO_EXECUTABLE to build msvc build Mono runtime used in BCL and Test build as well as runtime used when running tests.
335dcf9 to
0a3056f
Compare
luhenry
suggested changes
Oct 25, 2018
Contributor
luhenry
left a comment
There was a problem hiding this comment.
Love it! Only the --enable-msvc and it will all look perfect to me :)
configure.ac
Outdated
| AC_SUBST(mono_build_root) | ||
|
|
||
| mono_runtime=mono/mini/mono | ||
| AC_ARG_WITH(msvc, [ --with-msvc=yes,no Build with Visual Studio (msvc) (defaults to no)],[],[with_msvc=no]) |
Contributor
There was a problem hiding this comment.
Use AC_ARG_ENABLE so you have --enable-msvc. We overuse the --with-* which is not originally meant for a yes/no parameter. Then propagate that ENABLE_MSVC variable instead of WITH_MSVC.
Member
Author
There was a problem hiding this comment.
OK, will change. Original used --enable-msvc at a start but then I looked for other patterns that seemed to be using --with-*.
Member
Author
|
@monojenkins build failed |
luhenry
approved these changes
Oct 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to perform msvc mono runtime build as part of regular make build. By default, msvc build will not automatically but can be enabled using --enable-msvc argument passed to autogen.sh. Doing msvc build as part of regular make will automatically set MONO_EXECUTABLE to build msvc build Mono runtime used in BCL and Test build as well as runtime used when running tests. Build msvc binaries will also be part of make install, if enabled.
Running build using --enable-msvc removes the need to do separate msvc build (normally before running make) and setup MONO_EXECUTABLE to matching build binary later picked up by BCL/Test builds and test execution. Using --enable-msvc automatically makes sure a matching msvc runtime gets build and used based on used --host parameter. Doing a full Windows build, including msvc build can now be done like this:
./autogen.sh --prefix=$PREFIX --host=x86_64-w64-mingw32 --enable-msvc --disable-boehm
make -j4