[interp] throw overflow exception when {float,double}.NaN is converted to an int type #11380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to an int type A comparison with NaN is always `false`.
luhenry
approved these changes
Oct 25, 2018
Contributor
|
@monojenkins squash |
Contributor
|
@monojenkins build failed |
Contributor
|
Cannot squash because the following required status checks are not successful:
|
Contributor
Author
|
@monojenkins build failed |
1 similar comment
Contributor
Author
|
@monojenkins build failed |
Contributor
Author
|
@monojenkins backport 2018-06 |
Contributor
Author
|
@monojenkins backport 2018-08 |
Contributor
Author
|
@monojenkins backport 2018-10 |
Contributor
|
@lewurm backporting to 2018-06 failed, the patch results in conflicts: Please backport manually! |
Contributor
|
@lewurm could you please backport manually to |
lewurm
added a commit
to lewurm/mono
that referenced
this pull request
Oct 29, 2018
…d to an int type (mono#11380) [interp] throw overflow exception when {float,double}.NaN is converted to an int type A comparison with NaN is always `false`.
luhenry
pushed a commit
that referenced
this pull request
Oct 29, 2018
* [interp] Overflow fixes (#9688) * [interp] Fix some conv ovf opcodes * [interp] Correctly hande a few conv ovf cases For conversion from unsigned value to i1 and i2. * [interp] Fix multiplication overflow case * [interp] Remove some constants from code * [interp] throw overflow exception when {float,double}.NaN is converted to an int type (#11380) [interp] throw overflow exception when {float,double}.NaN is converted to an int type A comparison with NaN is always `false`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A comparison with NaN is always
false.