Take #2 - small implementation for not implemented member functions. #1191
Conversation
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
There was a problem hiding this comment.
Don't use the nameSpace field here, instead add a private setter to the ResourceType.Namespace property and use that.
|
Can you provide a unit test that covers these changes in ResourceTypeTest.cs? The commit message should also be updated to more clearly state the purpose of this change instead of just "small implementation ..." Thanks! |
|
Alexander, Should I close my current poll request to submit those changes? Regarding unit test, I looked at:
Thanks, From: Alexander Köplinger [mailto:[email protected]] Can you provide a unit test that covers these changes in ResourceTypeTest.cshttps://github.com/mono/mono/blob/master/mcs/class/System.Data.Services/Test/System.Data.Services.Providers/ResourceTypeTest.cs? The commit message should also be updated to more clearly state the purpose of this change instead of just "small implementation ..." Thanks! — |
|
You don't need to close this PR, instead you can modify your local branch, squash the changes and then force-push to GitHub to have it show up here. Here's a short guide that has more details: https://gist.github.com/janjongboom/7194742 (feel free to ask if anything is unclear). Regarding unit tests: the .csproj in |
|
Ok, thank you very much! Unfortunately, I won’t be able to make all those changes today – we are in agile here, I bet you know what I mean! I hope, I will have some spare time later this week, so will try to look at the unit tests setup first, and see whether I can include this file (ResourceTypeTests.cs) & add new one for ResourceProperty class as well. Thanks, From: Alexander Köplinger [mailto:[email protected]] You don't need to close this PR, instead you can modify your local branch, squash the changes and then force-push to GitHub to have it show up here. Here's a short guide that has more details: https://gist.github.com/janjongboom/7194742 (feel free to ask if anything is unclear). Regarding unit tests: the .csproj in mcs/class/System.Data.Services/Test/ you mentioned is likely a left-over and should be cleaned up, as the only one that matters is mcs/class/System.Data.Services/System.Data.Services-tests-net_XX.csproj — |
|
No problem, we're here for the long run ;-) |
Added class ExposedEncoder to test the virtual method Encoder.Convert behavior. Test UTF8Encoder.Convert override.
EncodingEncoder and EncodingDecoder override Encoder.Convert. The Convert overrides allow retrieval of chars/bytes buffers with the same size as .NET.
Since NET_4_0 and NET_4_5 share the same ToolsVersion (4.0) there seems no way to distinguish the appropriate framework .targets file, so I ended up to add the missing members as internal for 4.0.
… fixed address fails.
…eam. Fixes xambug #21982.
…ne support This optimization is activated in the ldvirtftn + delegate case, and is deactivated in the case where the architecture does not support it (mono_arch_get_delegate_virtual_invoke_impl return NULL)
This makes difference when the build has started from a solution especially via command line with /p option. Those command-line-passed properties need to be inherited to each project, but they weren't. xbuild worked fine here.
This is take #2, the first one failed code review - sorry to waste your time.
In this version, I made it working exactly the same way as in MS 4.5 implementation.
Thank you!