[Debugger] Crash test #12304
Merged
[Debugger] Crash test #12304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d73377.
…ady have knowledge about the unreliability of the crash reporter and the test is not about it. So if in 10 times at least one of them works for now it's good. Fixes mono#11385
vargaz
reviewed
Jan 7, 2019
Contributor
Author
|
@monojenkins build failed |
1 similar comment
Contributor
Author
|
@monojenkins build failed |
vargaz
approved these changes
Jan 8, 2019
Contributor
Author
|
@monojenkins build failed |
Contributor
|
It might be good to track this one down, the crash reporter is unreliable when dealing with random crashes, this one is a controlled one, so it should work. |
Contributor
Author
What do you suggest? What happens is that after the fork the parent process disappear(between the fork and this call mono_threads_summarize_execute) and only the child process continues. |
Contributor
Author
|
@monojenkins build failed |
1 similar comment
Contributor
Author
|
@monojenkins build failed |
Contributor
Author
|
@monojenkins build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the test behavior as discussed with Ludovic, because we already have knowledge about the unreliability of the crash reporter and the test is not about it.
So if in 10 times at least one of them works for now it's good.
Fixes #11385