[2018-08] [runtime] Fix building older runtimes with newer system Mono #12574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46f2a27 to
abfd8ba
Compare
What was happening was that this was building with a Mono.Cecil from the build profile, but was trying to load the system Mono.Cecil. Those versions mismatch when building 2018-08 with a nightly mono that is 5.23.0. Rather than messing with the MONO_PATH and risking shadowing something important there, I chose to copy the Mono.Cecil files into this "lib/build/tmp" directory that we are using for the emitted executable. It is loaded by the system Mono as the correct Mono.Cecil to use. This fixes the build.
abfd8ba to
570224b
Compare
Member
|
do we still need this? |
Contributor
|
@monojenkins build failed |
Contributor
|
Yes @akoeplinger, this commit was necessary to land the MERP 2018-08 backport because it is necessary to create the monolite. If we want to ever be able to land another monolite-bumping backport to 2018-08 using newer monos installed on CI, we will need this change. |
Member
|
Ok. Given that 2018-08 should only receive critical fixes by now I hope we won't need another monolite bump. If that happens we can reopen the PR :) |
Member
|
Turns out this is not just important for monolite but whenever you build using a new enough system mono so we do need this, reopening and merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was happening was that this was building with a Mono.Cecil from
the build profile, but was trying to load the system Mono.Cecil.
Those versions mismatch when building 2018-08 with a nightly mono that is 5.23.0.
Rather than messing with the MONO_PATH and risking shadowing something
important there, I chose to copy the Mono.Cecil files into this
"lib/build/tmp" directory that we are using for the emitted executable.
It is loaded by the system Mono as the correct Mono.Cecil to use, as assemblies in the same folder have precedence.
This fixes the build.
Backport of #12573.
/cc @alexanderkyte