Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

hi @knocte, sorry, don't have time

@linquize, my PR is reverting one of your commit,
can you take a look to see if you can find a better fix for your problem

@echampet I'm sorry, but this commit DOES require a unit test in order to be accepted. If there's none we risk a regression

@grendello, i know, but still don't have time

Sorry about that, but until someone comes up with a test, this commit cannot be accepted...

I don't think reverting this is the right way. The original PR #866 included some unit tests that were fixed by the commit so reverting it will make them fail.

We should instead see under what conditions we should fallback to ContentEncoding.HeaderName (which reads the globalization responseEncoding setting).

Please notify mono-deve-list and discuss this PR there.

Done http://lists.ximian.com/pipermail/mono-devel-list/2014-October/042130.html

What's the status of this? It's hard to justify accepting this without a test case.

hi @alexrp, reverting is not the way to go but there is still a regression with 3cc0e3f
https://bugzilla.xamarin.com/show_bug.cgi?id=23810

haven't looked for a while if it was fixed by someone else

@echampet I'm closing this, if you have time to verify that the regression is still there, it would be great if you can document that on bugzilla and ideally submit another PR with the proper fix+test :)

hi @lewurm
given the commit log (no activity on this file since jan 2015) i'm pretty sure regression is still there
bugzilla bug is still open ...

bugzilla bug is still open

It should be marked as NEEDINFO because you didn't provide a testcase or detailed steps to reproduce.

@knocte my ticket isn't crystal clear but the problem is dead simple
set <globalization requestEncoding="utf-8" responseEncoding="utf-8"/> in machine.config and look at the http headers of an aspx page, you should see content-type: text/html; charset=utf-8 and not content-type: text/html