[llvm] Make GOT a typed struct #13803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47fac53 to
611fd21
Compare
vargaz
approved these changes
Apr 2, 2019
Contributor
|
Looks good. |
Contributor
Author
|
@monojenkins build failed |
611fd21 to
ba4f43f
Compare
Contributor
Author
|
@monojenkins build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our LLVM IR is littered with bitcasts due to the GOT being currently an untyped array.
This allows opt to remove those bitcasts, and to then see that we aren't crafting pointers from ints that may alias to other memory we're working with.
These conversions can pose trouble for LLVM's alias analysis, causing it to give up.