Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[threads] avoid race between setting the state flag and suspension #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monojenkins merged 1 commit into from
Feb 3, 2016
Merged

[threads] avoid race between setting the state flag and suspension #2558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions mono/metadata/threads.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2306,9 +2306,6 @@ mono_thread_suspend (MonoInternalThread *thread)
}

thread->state |= ThreadState_SuspendRequested;

UNLOCK_THREAD (thread);

suspend_thread_internal (thread, FALSE);
return TRUE;
}
Expand Down Expand Up @@ -3290,9 +3287,6 @@ void mono_thread_suspend_all_other_threads (void)
thread->state &= ~ThreadState_AbortRequested;

thread->state |= ThreadState_SuspendRequested;

UNLOCK_THREAD (thread);

/* Signal the thread to suspend */
suspend_thread_internal (thread, TRUE);
}
Expand Down Expand Up @@ -4791,7 +4785,6 @@ suspend_thread_critical (MonoThreadInfo *info, gpointer ud)
static void
suspend_thread_internal (MonoInternalThread *thread, gboolean interrupt)
{
LOCK_THREAD (thread);
if (thread == mono_thread_internal_current ()) {
mono_thread_info_begin_self_suspend ();
//XXX replace this with better named functions
Expand Down