[2020-02] Fixes potential crash for Encoder.Convert #20522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetByteCount will not return the right number of bytes needed, so GetBytes in Encoder.Convert will crash for some input
akoeplinger
approved these changes
Oct 28, 2020
Member
akoeplinger
left a comment
There was a problem hiding this comment.
Requested by VSMac in #20271 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetByteCount will not return the right number of bytes needed, so GetBytes in Encoder.Convert will crash for some input
Backport of #20271.
/cc @akoeplinger @jeffgoku