Add support for OP_FCONV_TO_I to mini-arm64.c. #20548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial backport of mono#20100. Also see: dotnet/runtime#35008 (comment)
akoeplinger
approved these changes
Nov 4, 2020
Contributor
Author
|
@monojenkins build failed |
1 similar comment
Contributor
Author
|
@monojenkins build failed |
Contributor
|
Shouldn't it fallback to OP_FCONV_TO_I8 on 64-bit platforms? I mean, mini-amd64 has it wrong too, but LLVM backend seem to respect the pointer size. |
Contributor
Author
|
It probably should, and that's something that I wondered when I eyeballed the existing code for our native backends, all of which seem to get this wrong, except for, as you note, the LLVM backend. I'll follow up on this in a separate PR; this PR moves us from "broken in a loud way" to "broken in the same obscure way as almost all our other backends" and also sets us up for a followup patch that should be automatically backportable. |
Contributor
Author
|
@monojenkins build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial backport of #20100.
Should fix #20533.
Also see:
dotnet/runtime#35008 (comment)