Use explicit arithmetic checks in the amd64 watchOS simulator. #20639
Conversation
|
Thanks a lot @imhameed! Can we get this back ported to 2020-02? |
|
Yeah; I'll do that once this makes it through. (I haven't actually reproduced the failure or verified that the fix actually works yet, so I'll need a little time to roll my iDevice setup forward.) |
|
Gotcha, thanks! Let me know if I can help somehow |
|
Any idea why we didn't catch this earlier ? @dalexsoto |
|
@SamMonoRT for the 32-bit simulator it didn't happen because Line 194 in 0e3d75d |
|
@SamMonoRT Because this is new for WatchOS 7.0+ and I did not catch it here #20553 because this was merged in xamarin-macios in a way that the bcl test triggered for a previous commit that did not contain this fix so we caught it on a subsequent commit |
|
@monojenkins build failed |
|
@imhameed any chance we can have this change pushed into a no shipping branch inside mono repo so the CI generates the binaries? this way I can help to test the change |
|
@monojenkins backport to 2020-02 |
Fixes #20632. Backport of #20639. Co-authored-by: Imran Hameed <[email protected]>
Fixes #20632.