Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the System.String.Replace throwing NotImplementedException #20960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2021
Merged

Fix the System.String.Replace throwing NotImplementedException #20960

merged 2 commits into from
Mar 26, 2021

Conversation

@MaximLipnin
Copy link
Contributor

@MaximLipnin MaximLipnin commented Mar 23, 2021

@marek-safar
Copy link
Member

marek-safar commented Mar 23, 2021

Please add/enable tests for this code path

@akoeplinger
Copy link
Member

akoeplinger commented Mar 24, 2021

@monojenkins build

@MaximLipnin
Copy link
Contributor Author

MaximLipnin commented Mar 25, 2021

@monojenkins build failed

@MaximLipnin
Copy link
Contributor Author

MaximLipnin commented Mar 25, 2021

@monojenkins build Linux i386

@akoeplinger
Copy link
Member

akoeplinger commented Mar 25, 2021

@monojenkins whitelist

@akoeplinger
Copy link
Member

akoeplinger commented Mar 25, 2021

@monojenkins build failed

@akoeplinger
Copy link
Member

akoeplinger commented Mar 26, 2021

The failures are unrelated, merging.

@akoeplinger akoeplinger merged commit 66f2883 into mono:main Mar 26, 2021
@MaximLipnin MaximLipnin deleted the issue-20948 branch March 26, 2021 13:39
MaximLipnin added a commit to MaximLipnin/mono that referenced this pull request Mar 26, 2021
@MaximLipnin
Fix the System.String.Replace throwing NotImplementedException (mono#…
9e1bbbc 
…20960)

mono#20948
@MaximLipnin MaximLipnin mentioned this pull request Mar 26, 2021
Merged
akoeplinger pushed a commit that referenced this pull request Mar 27, 2021
@MaximLipnin
Fix the System.String.Replace throwing NotImplementedException (#20960)…
69cfb5f 
… (#20978)

#20948
UnityAlex pushed a commit to Unity-Technologies/mono that referenced this pull request Sep 25, 2025
@MaximLipnin @UnityAlex
Fix the System.String.Replace throwing NotImplementedException (mono#…
32c9d0a 
…20960)

mono#20948
UnityAlex pushed a commit to Unity-Technologies/mono that referenced this pull request Sep 29, 2025
@MaximLipnin @UnityAlex
Fix the System.String.Replace throwing NotImplementedException (mono#…
a38361c 
…20960)

mono#20948
UnityAlex pushed a commit to Unity-Technologies/mono that referenced this pull request Sep 29, 2025
@MaximLipnin @UnityAlex
Fix the System.String.Replace throwing NotImplementedException (mono#…
ea72b10 
…20960)

mono#20948
UnityAlex pushed a commit to Unity-Technologies/mono that referenced this pull request Sep 29, 2025
@MaximLipnin @UnityAlex
Fix the System.String.Replace throwing NotImplementedException (mono#…
cd9d738 
…20960)

mono#20948
UnityAlex pushed a commit to Unity-Technologies/mono that referenced this pull request Sep 29, 2025
@MaximLipnin @UnityAlex
Fix the System.String.Replace throwing NotImplementedException (mono#…
94ebd83 
…20960)

mono#20948
UnityAlex added a commit to Unity-Technologies/mono that referenced this pull request Sep 30, 2025
@UnityAlex
Merge pull request #2192 from Unity-Technologies/6000.4-backport-117367
52677a7 
[6000.4] Fix the System.String.Replace throwing NotImplementedException (mono#20960)
UnityAlex added a commit to Unity-Technologies/mono that referenced this pull request Sep 30, 2025
@UnityAlex
Merge pull request #2193 from Unity-Technologies/6000.3-backport-117367
7e562e2 
[6000.3] Fix the System.String.Replace throwing NotImplementedException (mono#20960)
UnityAlex added a commit to Unity-Technologies/mono that referenced this pull request Sep 30, 2025
@UnityAlex
Merge pull request #2194 from Unity-Technologies/6000.2-backport-117367
c9418e2 
[6000.2] Fix the System.String.Replace throwing NotImplementedException (mono#20960)
UnityAlex added a commit to Unity-Technologies/mono that referenced this pull request Sep 30, 2025
@UnityAlex
Merge pull request #2195 from Unity-Technologies/6000.0-backport-117367
0c500f4 
[6000.0] Fix the System.String.Replace throwing NotImplementedException (mono#20960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@steveisok steveisok Awaiting requested review from steveisok

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaximLipnin @marek-safar @akoeplinger