[2020-02][System.Native] Handle ReadDir EINTR #21029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle EINTR for opendir/readdir/closedir. Because of how thread aborts work, we must loop in managed. A thread abort will break syscalls and return EINTR, but mono will not raise a ThreadAbortException until a pinvoke returns. (Despite the documentation, opendir/readdir/closedir sometimes return EINTR on macOS Big Sur.) Related to mono#20799
on mac it's in corlib, on unix and android it's in System, for some reason
Member
Author
|
@steveisok @akoeplinger please review this one and #21016 |
steveisok
approved these changes
Apr 23, 2021
Member
Author
|
@monojenkins build failed |
Member
Author
|
@akoeplinger @steveisok Windows and Linux/Intel lanes seem stuck. |
Member
Author
|
@monojenkins build |
akoeplinger
approved these changes
Apr 28, 2021
Member
|
@monojenkins build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #21016
Handle EINTR for opendir/readdir/closedir.
Because of how thread aborts work, we must loop in managed.
A thread abort will break syscalls and return EINTR, but mono will not raise a
ThreadAbortException until a pinvoke returns.
(Despite the documentation, opendir/readdir/closedir sometimes return EINTR on
macOS Big Sur.)
Related to #20799
Bump corefx to mono/corefx@9174bbeb7e