transform sgen_get_descriptor to parallel safe version in job_major_mod_union_preclean #21384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od_union_preclean fixes mono#21369 job_major_mod_union_preclean can race with the tarjan bridge implementation that changes the vtable pointer by settings the three lower bits. this results in invalid loading of the vtable (shifted by 7 bytes) which in turn give a wrong desc to the scan functions This change is released under the MIT license.
Member
|
@tmijieux Many thanks for the fix. We should have this backported everywhere. |
BrzVlad
approved these changes
Dec 30, 2021
Contributor
|
/azp run mono-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@monojenkins build |
Member
|
/backport to 2020-02 |
Contributor
|
Started backporting to 2020-02: https://github.com/mono/mono/actions/runs/1650198102 |
Member
|
/azp run sync-mono-to-runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Jan 5, 2022
Fixes: #6546 Context: mono/mono#21384 Changes: mono/mono@b8d7525...a5d1934 * mono/mono@a5d1934898b: transform sgen_get_descriptor to parallel safe version in job_major_mod_union_preclean (#21391)
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Jan 5, 2022
Fixes: #6546 Context: mono/mono#21384 Changes: mono/mono@b8d7525...a5d1934 * mono/mono@a5d1934898b: transform sgen_get_descriptor to parallel safe version in job_major_mod_union_preclean (#21391)
ThomasKuehne
pushed a commit
to ThomasKuehne/mono
that referenced
this pull request
Mar 23, 2024
…od_union_preclean (mono#21384) fixes mono#21369 Related to dotnet/android#6546 job_major_mod_union_preclean can race with the tarjan bridge implementation that changes the vtable pointer by settings the three lower bits. this results in invalid loading of the vtable (shifted by 7 bytes) which in turn give a wrong desc to the scan functions This change is released under the MIT license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21369
Related to dotnet/android#6546
job_major_mod_union_preclean can race with the tarjan bridge
implementation that changes the vtable pointer by settings the three
lower bits. this results in invalid loading of the vtable
(shifted by 7 bytes) which in turn give a wrong desc to the scan
functions
This change is released under the MIT license.