Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jo-oe
Copy link

@jo-oe jo-oe commented Apr 9, 2024

Avoids segfault when working with zlib-ng.
See:
zlib-ng/zlib-ng#1708

@jo-oe jo-oe requested a review from lambdageek as a code owner April 9, 2024 14:58
@jo-oe
Copy link
Author

jo-oe commented Apr 9, 2024

@dotnet-policy-service agree

@CodeDead
Copy link

Thanks @jo-oe

@karlp
Copy link

karlp commented Jun 21, 2024

What's actually blocking this right now? the azure build logs are gone, so i can't see what failed. I'm stuck with fedora having merged a fix for their packages, but they don't target the required dotnet runtime version, and the mono centos8 repository, which otherwise has the right target runtime support, doesn't have this fix in it.

@tuliom
Copy link

tuliom commented Jun 21, 2024

What's actually blocking this right now? the azure build logs are gone, so i can't see what failed. I'm stuck with fedora having merged a fix for their packages, but they don't target the required dotnet runtime version, and the mono centos8 repository, which otherwise has the right target runtime support, doesn't have this fix in it.

@karlp I suggest that you report this issue downstream to these distributions.

Getting this issue merged here (upstream) won't guarantee these distributions will have the fix.

@karlp
Copy link

karlp commented Jun 21, 2024

When I say the "mono centos 8 repo" I actually mean this one: https://download.mono-project.com/repo/index.html from mono itself. My distro (fedora in this case) has already merged this fix, but their package doesn't target the "right" runtime, so I can't use it to build Renode So yeah, I'm hoping to get it into a mono tree at some point, not just downstreams.

@belegdol
Copy link

belegdol commented Nov 2, 2025

Ping @madewokherd - could this be merged in the new upstream? It is not in 6.14.1. Thanks!

@fweimer-rh
Copy link

Is this solved by zlib-ng/zlib-ng#1713?

@tuliom
Copy link

tuliom commented Dec 8, 2025

Is this solved by zlib-ng/zlib-ng#1713?

@fweimer-rh IMHO, it only works around the issue here.
The zlib documentation explicitly says:

The application must initialize zalloc, zfree and opaque before calling the init function.

Source: https://www.zlib.net/manual.html#Usage

There is a chance this is going to crash again if mono doesn't fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants