Implementation of some corlib classes #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello Kenneth, For new classes there is very little feedback that I can provide, but in a handful of cases you made changes that change the existing behavior (for example on NTAccount the _value is now set to name, instead of name.ToUpper ()). In those cases, it would be useful if you could state on your commit message why those changes are necessary. |
Author
|
Thanks - I've updated the commit message on that change, to add: NTAccount changed to not upper-case values to match behaviour observed in Microsoft's .NET (see also unit tests). Cheers, Ken |
added 2 commits
December 22, 2010 01:11
* Only translates between SecurityIdentifier and NTAccount for
well-known accounts.
* NTAccount changed to not upper-case values to match behaviour
observed in Microsoft's .NET (see also unit tests)
* Add unit tests for both classes
* Marshals to/from SDDL and binary form. * Supports 'Common' ACEs and 'Object' ACEs
Contributor
|
Applied. Thanks! |
luliyi1024
referenced
this pull request
in luliyi1024/mono
Sep 29, 2012
…y3.5-staging Unity3.5 staging - fixing clobbered r8 on android (when script debugging is enabled)
Closed
luhenry
pushed a commit
to luhenry/mono
that referenced
this pull request
Nov 11, 2018
* Get element from int array. * Support modulo, array set, branch on boolean.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes implement:
The changes ripple through to a number of associated classes (representing ACEs and ACLs).
Although some functionality is limited (can't do SID --> Name and Name --> SID translations for arbitrary accounts), it is enough to load, manipulate and store Security Descriptors in binary and SDDL form.
There are some unit tests included, that all pass on Microsoft's .NET.