Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix bug in BlockingCollection<T>.TryTake #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Dec 7, 2010
Merged

Fix bug in BlockingCollection<T>.TryTake #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mcs/class/System/System.Collections.Concurrent/BlockingCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ bool TryTake (out T item, Func<bool> contFunc, CancellationToken token)

if (!mreRemove.IsSet)
mreRemove.Set ();
return true;
} while (contFunc ());

return false;
Expand Down
16 changes: 16 additions & 0 deletions mcs/class/System/Test/System.Collections.Concurrent/BlockingCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,22 @@ public void ConsumingEnumerableTestCase()
}
Assert.AreEqual(0, defaultCollection.Count, "#" + i);
}

[TestAttribute]
public void TryTakeTestCase ()
{
defaultCollection.Add (1);

int value = default (int);
bool firstTake = defaultCollection.TryTake (out value);
int value2 = default (int);
bool secondTake = defaultCollection.TryTake (out value2);

Assert.AreEqual (1, value);
Assert.IsTrue (firstTake);
Assert.AreEqual (default (int), value2);
Assert.IsFalse (secondTake);
}
}
}
#endif