Loop support for Mono.CSharp.Evaluator Terse Mode #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Using a regular expression for detecting this is too fragile. What I would rather do is this: just like we have a retry for ';', we should have a retry by adding a block '{}', if this one succeeds in parsing, we assume that we need a continuation. Otherwise we try the ';' |
Contributor
|
I added the correct fix to master. |
Author
|
Ah, much nicer solution. Catches "if (a > b)" too, which escaped my attention before. |
Red54
pushed a commit
to Red54/mono
that referenced
this pull request
Mar 15, 2019
Fix two bugs in Unity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Terse mode automatically adds a semi-colon to partial inputs it causes inputs like "for (int ii = 0; ii < 3; ii++)", or "while (ii < 3)" to execute immediately with no body in the loop, rather than waiting for further input.
This pull request fixes that problem by detecting loop expressions using a Regex, and not attempting to complete them by adding a semi-colon.