Wait for the native thread to die in Thread.Join() on Windows #5504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the behavior of .NET. After this patch the code on Mono for Windows will make sure the underlying native thread of a managed thread has died before Thread.Join() returns. This PR builds on PR mono#5454 but makes it Windows specific. PR mono#5454 was reverted since it caused crashes on some Unix platforms.
akoeplinger
reviewed
Sep 5, 2017
Member
akoeplinger
left a comment
There was a problem hiding this comment.
LGTM, I assume Zoltan is still looking at the Unix portion?
Contributor
Author
Contributor
|
LGTM |
kumpera
approved these changes
Sep 8, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ad-to-die-in-Thread-Join Wait for the native thread to die in Thread.Join() on Windows Commit migrated from mono/mono@f98d079
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the behavior of .NET. After this patch the code on Mono for Windows will make sure the underlying native thread of a managed thread has died before
Thread.Join()returns.This PR builds on PR #5454 but makes it Windows specific. PR #5454 was reverted since it caused crashes on some Unix platforms.