[threads] Check if thread ids are != NULL (0) #5541
Conversation
|
@cherusker, |
c8f47be to
64381ac
Compare
|
Will not be needed if #5549 succeeds. |
| * we have time (in he finalizer thread). | ||
| */ | ||
| if (tid == NULL) { | ||
| g_warning ("Invalid thread: %p", tid); |
There was a problem hiding this comment.
This should be a g_assert (tid);
There was a problem hiding this comment.
That would not provide a workaround for this bug: the build would continue to stop early (and would so, on even more platforms than it does so far) since g_assert () definitely stops the program on any platform. https://github.com/luhenry/mono/blob/6928fda088c549648b0483e4e88c1d3dcdfdda30/mono/metadata/gc.c#L998 adds 0 to the list of threads which ends up here. The idea behind using g_warning () was to have something that does not exit the runtime but still sends a strong message/warning.
After all, I really hope that #5549 succeeds somehow. This would make this PR irrelevant as it fixes the bug cleanly at its very root.
|
These changes are no longer necessary due to #5615 |
I would like to propose this fix to avoid https://bugzilla.xamarin.com/show_bug.cgi?id=59371 and similar issues in the future. It only targets a part of the whole issue but I think it's really important to have these checks; independent of how #59371 is being fixed.