Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Mono on MIPS, backend fixes for mono-2-6 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4 commits merged into from
Feb 10, 2011
Merged

Mono on MIPS, backend fixes for mono-2-6 #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d2da4d
MIPS: Throw OverflowException if Int32.MinValue is divided by -1
ztzg Feb 1, 2011
64e3e31
MIPS: Use SLTU to implement COND_EXC_LE_UN (Exception when <= unsigned)
ztzg Feb 2, 2011
ba12aea
MIPS: Fix unboxing trampolines for functions returning value types
ztzg Feb 3, 2011
d1c7b1a
MIPS: Ignore float->int overflow behaviour, as on PPC, ARM, and SPARC
ztzg Feb 7, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mono/mini/cpu-mips.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,10 @@ not_null: src1:i len:0
int_add: dest:i src1:i src2:i len:4
int_sub: dest:i src1:i src2:i len:4
int_mul: dest:i src1:i src2:i len:4
int_div: dest:i src1:i src2:i len:76
int_div: dest:i src1:i src2:i len:84
int_div_un: dest:i src1:i src2:i len:40
int_rem: dest:i src1:i src2:i len:76
int_rem_un: dest:i src1:i src2:i len:76
int_rem: dest:i src1:i src2:i len:84
int_rem_un: dest:i src1:i src2:i len:40
int_and: dest:i src1:i src2:i len:4
int_or: dest:i src1:i src2:i len:4
int_xor: dest:i src1:i src2:i len:4
Expand Down
2 changes: 1 addition & 1 deletion mono/mini/iltests.il.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,7 +963,7 @@ COND: ldloc.0
ret
}

#if !defined(__ppc__) && !defined(__powerpc__) && !defined(__arm__) && !defined(__sparc__)
#if !defined(__ppc__) && !defined(__powerpc__) && !defined(__arm__) && !defined(__sparc__) && !defined(__mips__)
// PPC handles overflow by clipping, but this test assumes
// no overflow handling. According to ECMA the result of
// float->int conversion is undefined if overflow occurs, so
Expand Down
16 changes: 10 additions & 6 deletions mono/mini/mini-mips.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3370,18 +3370,22 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
case OP_IDIV:
case OP_IREM: {
guint32 *divisor_is_m1;
guint32 *dividend_is_minvalue;
guint32 *divisor_is_zero;

/* */
mips_addiu (code, mips_at, mips_zero, 0xffff);
mips_load_const (code, mips_at, -1);
divisor_is_m1 = (guint32 *)(void *)code;
mips_bne (code, ins->sreg2, mips_at, 0);
mips_lui (code, mips_at, mips_zero, 0x8000);
dividend_is_minvalue = (guint32 *)(void *)code;
mips_bne (code, ins->sreg1, mips_at, 0);
mips_nop (code);

/* Divide by -1 -- throw exception */
EMIT_SYSTEM_EXCEPTION_NAME("ArithmeticException");
/* Divide Int32.MinValue by -1 -- throw exception */
EMIT_SYSTEM_EXCEPTION_NAME("OverflowException");

mips_patch (divisor_is_m1, (guint32)code);
mips_patch (dividend_is_minvalue, (guint32)code);

/* Put divide in branch delay slot (NOT YET) */
divisor_is_zero = (guint32 *)(void *)code;
Expand Down Expand Up @@ -3945,9 +3949,9 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
break;

case OP_MIPS_COND_EXC_LE_UN:
mips_subu (code, mips_at, ins->sreg1, ins->sreg2);
mips_sltu (code, mips_at, ins->sreg2, ins->sreg1);
throw = (guint32 *)(void *)code;
mips_blez (code, mips_at, 0);
mips_beq (code, mips_at, mips_zero, 0);
mips_nop (code);
break;

Expand Down
7 changes: 2 additions & 5 deletions mono/mini/tramp-mips.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,13 @@ gpointer
mono_arch_get_unbox_trampoline (MonoGenericSharingContext *gsctx, MonoMethod *m, gpointer addr)
{
guint8 *code, *start;
int this_pos = mips_a0;
MonoDomain *domain = mono_domain_get ();

if (MONO_TYPE_ISSTRUCT (mono_method_signature (m)->ret))
this_pos = mips_a1;

start = code = mono_domain_code_reserve (domain, 20);

mips_load (code, mips_t9, addr);
mips_addiu (code, this_pos, this_pos, sizeof (MonoObject));
/* The this pointer is kept in a0 */
mips_addiu (code, mips_a0, mips_a0, sizeof (MonoObject));
mips_jr (code, mips_t9);
mips_nop (code);

Expand Down