[runtime] Don't crash when method/assembly with no code coverage does… #5798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
reviewed
Oct 17, 2017
mono/metadata/profiler.c
Outdated
Contributor
There was a problem hiding this comment.
Preferred code style in the runtime is if (!minfo).
vargaz
approved these changes
Oct 17, 2017
… not have debug symbols
8c0fcdd to
c84b6ea
Compare
chamons
pushed a commit
to chamons/mono
that referenced
this pull request
Nov 16, 2017
Instead of hijacking the return address when suspending a thread in a finally block for an abort, do an explicit check in managed code when we are returning from the handler in order to see if we need to abort. Hijacking the return address is arch specific and it doesn't work if we are suspended before it is initialized in handler start. Fixes mono#5798
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Instead of hijacking the return address when suspending a thread in a finally block for an abort, do an explicit check in managed code when we are returning from the handler in order to see if we need to abort. Hijacking the return address is arch specific and it doesn't work if we are suspended before it is initialized in handler start. Fixes mono/mono#5798 Commit migrated from mono/mono@ba95f34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… not have debug symbols