Allow deferred attaching in the soft debugger #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* mini/debugger-agent.c: Don't double-emit assembly nor type load information. License: MIT/X11
* mini/debugger-agent.c: Ensure the VM resumes when detaching. License: MIT/X11
* mini/debugger-agent.c: Ensure that client listener doesn't block VM exit. License: MIT/X11
* Mono.Debugger.Soft/Connection.cs: Allow connection close without forcing the VM to exit. * Mono.Debugger.Soft/VirtualMachine.cs: Allow VM disconnection without forcing the VM to exit. License: MIT/X11
* mini/debugger-agent.c: Cleanup debug output. License: MIT/X11
* mini/debugger-agent.c: Clear pending typeloads when unloading, remove appdomain from table earlier, take loader lock. License: MIT/X11
* mini/debugger-agent.c: Add functions for emitting thread start. License: MIT/X11
* mini/debugger-agent.c: Cleanup state transmission on attach. License: MIT/X11
* mini/debugger-agent.c: Cleanup event processing while attaching. License: MIT/X11
* mini/debugger-agent.c: Don't pend assembly loads while waiting for attach. License: MIT/X11
* mini/debugger-agent.c: Reset pre-attach state on detach. License: MIT/X11
* mini/debugger-agent.c: Autogenerate default port based on PID. License: MIT/X11
* mini/debugger-agent.c: Listen on any address when deferring. License: MIT/X11
* mono/mini/debugger-agent.c: Remove thread start assert that's now nonsensical. License: MIT/X11
…ent on attach. * mono/mini/debugger-agent.c: Remove unused type load pending. License: MIT/X11
* debugger-agent.c: Fix race-to-crash on runtime shutdown. License: MIT/X11
* debugger-agent.c: Unregress non-windows runtime shutdown. License: MIT/X11
…chments. * debugger-agent.c: Allow runtime to survive not being able to listen for attachments. License: MIT/X11
* debugger-agent.c: Fix build. License: MIT/X11
Contributor
|
I don't think the 'defer' argument is needed, server=y,suspend=n should accomplish the same. |
Contributor
Author
|
Just the argument, or the rest of the changes? |
Contributor
|
Just the argument, server=y,suspend=n means the debugger thread will start up, wait for a connection, but the rest of the runtime will run normally. At least thats what happens in java. |
Contributor
Author
|
Ok, so you just want me to rework the argument handling? |
Contributor
|
Yes. I prefer keeping our arguments the same as in java. |
* debugger-agent.c: Replace defer=y with server=y,suspend=n. License: MIT/X11
Contributor
|
Could we get the mono/man/mono.1 page documented as well? |
* mono.1: Add information about suspend suboption. License: MIT/X11
Contributor
Author
|
Obsoleting in favor of #54 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT/X11