[msbuild] Empty commit to trigger wrench build and pick up msbuild ch… #5192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges Specifically to get mono/msbuild@985f169 [mono] Update bundled sdks: .NET Core SDK 1.1.0 Preview 1 (#17) .. to match what is bundled with VS 15.3 Ref: dotnet/announcements#19
Contributor
|
2017-04 is closed for commits. What are these changes for? |
Contributor
|
Also, how does this commit pick up msbuild changes? |
Member
Author
|
It would pick up because of this bump in bockbuild - https://github.com/xamarin/bockbuild/pull/94/commits/c7b3331940d3e3fb52e87e0b6ec5cb4afa87a0c6 . |
Member
Author
akoeplinger
approved these changes
Jul 10, 2017
Member
akoeplinger
left a comment
There was a problem hiding this comment.
LGTM (you did work with QA on this right?)
Member
Author
|
@akoeplinger opened a request with QA for this. They will decide whether or not to merge, I guess! |
Member
Author
|
I will apply the update to 2017-06 instead since it is too late for QA to accept this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…anges
Specifically to get
mono/msbuild@985f169
[mono] Update bundled sdks: .NET Core SDK 1.1.0 Preview 1 (#17)
.. to match what is bundled with VS 15.3
Ref: dotnet/announcements#19