Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[runtime] Fix the size calculation for CustomAttributeType coded indexes, they can only point to the MethodDef/MemberRef tables even through 3 bits are used to encode them, only 2 values are used. Fixes #58210. #5256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vargaz merged 1 commit into from
Jul 25, 2017
Merged

[runtime] Fix the size calculation for CustomAttributeType coded indexes, they can only point to the MethodDef/MemberRef tables even through 3 bits are used to encode them, only 2 values are used. Fixes #58210. #5256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions mono/metadata/metadata.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,21 +836,11 @@ mono_metadata_compute_size (MonoImage *meta, int tableindex, guint32 *result_bit
break;

/*
* CustomAttributeType: TypeDef, TypeRef, MethodDef,
* MemberRef and String.
* CustomAttributeType: MethodDef, MemberRef.
*/
case MONO_MT_CAT_IDX:
/* String is a heap, if it is wide, we know the size */
/* See above, nope.
if (meta->idx_string_wide){
field_size = 4;
break;
}*/

n = MAX (get_nrows (meta, MONO_TABLE_TYPEREF),
get_nrows (meta, MONO_TABLE_TYPEDEF));
n = MAX (n, get_nrows (meta, MONO_TABLE_METHOD));
n = MAX (n, get_nrows (meta, MONO_TABLE_MEMBERREF));
n = MAX (get_nrows (meta, MONO_TABLE_METHOD),
get_nrows (meta, MONO_TABLE_MEMBERREF));

/* 3 bits to encode */
field_size = rtsize (meta, n, 16-3);
Expand Down